Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics state uses quantity #353

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Physics state uses quantity #353

merged 4 commits into from
Oct 17, 2022
+249 −125

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Oct 10, 2022 •
edited
Loading

Purpose

#211

Code changes:

  • state.py: remove physics specific restart
  • physics_state.py: all storages are now quantity, added init from storages for translate test
  • microphysics.py: microphysics state also uses quantity
  • translate_microphysics.py: make physics state from storages

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

Additionally, if this PR contains code authored by new contributors:

  • The names of all the new contributors have been added to CONTRIBUTORS.md

@elynnwu elynnwu requested a review from jdahm October 12, 2022 17:13
@elynnwu elynnwu enabled auto-merge (squash) October 13, 2022 16:49
jdahm
jdahm approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@jdahm jdahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It's a nice step forward to use Quantity consistently in Pace.

@elynnwu
Copy link
Collaborator Author

elynnwu commented Oct 13, 2022

launch jenkins

1 similar comment
@elynnwu
Copy link
Collaborator Author

elynnwu commented Oct 17, 2022

launch jenkins

@elynnwu elynnwu merged commit fd078b0 into main Oct 17, 2022
@elynnwu elynnwu deleted the feature/physics-state-quantity branch October 17, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdahm jdahm jdahm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elynnwu @jdahm